[Mesa-dev] [PATCH 0/8] gallium: A number of video code fixes

[Christian König]

Am 22.02.2017 um 16:31 schrieb Thomas Hellstrom:
> On 02/22/2017 04:00 PM, Emil Velikov wrote:
>> On 22 February 2017 at 09:30, Thomas Hellstrom <thellstrom at vmware.com> wrote:
>>> On 02/22/2017 09:56 AM, Christian König wrote:
>>>> Am 21.02.2017 um 21:52 schrieb Thomas Hellstrom:
>>>>> A couple of fixes / improvements for things I've encountered while
>>>>> looking
>>>>> through and testing the video code in preparation for a virtual
>>>>> hardware video
>>>>> driver.
>>>> Reviewed-by: Christian König <christian.koenig at amd.com> for the whole
>>>> set.
>>> Thanks for the review, Christian.
>> Worth getting the lot to -stable ? Adding either "cc: mesa-stable..."
>> or "Fixes: $sha1 ("$commit summary")" will do.
>>
>> Haven't looked at the series, so not sure how much of the work is
>> safe/applicable.
>>
>> Thanks
>> Emil
> Hi, Emil,
>
> There is only one significant bugfix in that series, (the vdpau
> multithreading fix), but I'm not sure how and if it affects the current
> drivers.

Actually thinking more about it that change might be incorrect after all.

The pipe a decoder is created from can be accessed concurrently together 
with the decoder.

E.g. you can hammer on the pipe from thread A and on the decoder from 
thread B at the same time and that is fine.

Otherwise you run into a bunch of stalling problems with Kodi for example.

Your solution of creating a separate pipe object might work as well, but 
I think that could cause problems with the cached sampler views later on.

Regards,
Christian.

> I hit this problem with mpv --vo vdpau --hwdec vdpau <video_clip>.
>
> In any case it should probably sit in master for a while before we
> decide to crossport.
>
> /Thomas
>
>