[Mesa-dev] [PATCH] glx/glvnd: Fix GLXdispatchIndex sorting

[Kyle Brenneman]

On 02/20/2017 01:32 AM, Hans de Goede wrote:
> Hi Emil,
>
> On 16-02-17 16:38, Emil Velikov wrote:
>> Hi Hans,
>>
>> On 6 February 2017 at 13:09, Hans de Goede <hdegoede at redhat.com> wrote:
>>> Commit 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and 
>>> indices")
>>> fixed the sorting of the array initializers in 
>>> g_glxglvnddispatchfuncs.c
>>> because FindGLXFunction's binary search needs these to be sorted
>>> alphabetically.
>>>
>>> That commit also mostly fixed the sorting of the DI_foo defines in
>>> g_glxglvnddispatchindices.h, which is what actually matters as the
>>> arrays are initialized using "[DI_foo] = glXfoo," but a small error
>>> crept in which at least causes glXGetVisualFromFBConfigSGIX to not
>>> resolve, breaking games such as "The Binding of Isaac: Rebirth" and
>>> "Crypt of the NecroDancer" from Steam not working and possible causes
>>> other problems too.
>>>
>>> This commit fixes the last of the sorting errors, fixing these 
>>> mentioned
>>> games not working.
>>>
>>> Fixes: 8bca8d89ef3b ("glx/glvnd: Fix dispatch function names and 
>>> indices")
>>> Cc: "13.0" <mesa-stable at lists.freedesktop.org>
>>> Cc: "17.0" <mesa-stable at lists.freedesktop.org>
>>> Cc: Adam Jackson <ajax at redhat.com>
>>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>>> ---
>> A while back as Adam did a similar thing, it was suggested that we get
>> an actual test so that things don't break.
>>
>> I was stupid^Wkind enough to opt for "we can have such patch as
>> follow-up", only that it never came.
>> As you can imagine not cool...
>
> Sorry, but for me this was sort of a drive by patch and I don't really
> have time to work on a test for this. But it looks like ajax owes you
> a test-case for this, ajax ?
>
> Also Kyle Brenneman (added to the CC) who helped me pinpoint the issue
> to the sorting problem mentioned that he was working on a patch to
> autogenerate the files in question to avoid breakage like this,
> Kyle what is the status of that ?
>
> Regards,
>
> Hans

I've got the generation patch almost done. I'm hoping to have it ready 
by this afternoon.

-Kyle