[Mesa-dev] [PATCH 8/8] r600/radeonsi: enable glsl/tgsi on-disk cache

Matt Turner mattst88 at gmail.com
Wed Feb 22 22:20:54 UTC 2017


On Wed, Feb 22, 2017 at 2:12 PM, Timothy Arceri <tarceri at itsqueeze.com> wrote:
> On 23/02/17 08:46, Matt Turner wrote:
>> On Tue, Feb 21, 2017 at 7:45 PM, Timothy Arceri <tarceri at itsqueeze.com>
>> wrote:
>>>
>>> For gpu generations that use LLVM we create a timestamp string
>>> containing both the LLVM and Mesa build times, otherwise we just
>>> use the Mesa build time.
>>
>>
>> Why not use the build id for Mesa?
>>
>
> I would rather be using the same mechanism for both. I need to check if
> anything needs to be done to use this with llvm, in the meantime this allows
> me to get things into master and get some user feedback which is critical to
> be able to enable this be default next release.

Right, okay.

I might suggest attempting to use the build id first (return val of
build_id_find_nhdr() would be NULL if build id is not present) and
fallback to the timestamp.

As far as I'm aware, binaries shipped by Fedora, Debian, Ubuntu, and
Arch all have build-ids. Gentoo does not, but I expect that's
something I can fix.


More information about the mesa-dev mailing list