[Mesa-dev] [PATCH mesa v2] glx: add GLXdispatchIndex sort check
emil.l.velikov at gmail.com
Thu Feb 23 16:07:36 UTC 2017
You're a star Eric, thank you !
On 22 February 2017 at 11:24, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> v2: make sure the list is in the order C's strcmp uses (Ilia)
> Ilia: I used LC_ALL instead of LANG, as it takes precedence
> (ie. LANG=C in this script would be overridden by
> LC_ALL=en_US in the environment).
Personally I'm safe even without the LC_ALL bit, but it seems like a good idea.
Perhaps we want that for the EGL test as well ?
In both cases we really want to set srcdir, such that ./dispatch-index-check and
../some/crazy/path/to/dispatch-index-check also work.
Perhaps reuse the autogen.sh magic ?
Feel free to do that as follow-up or let me know otherwise and I'll
fix it. I'm just fixing our "broken since day 1" glsl tests ;-)
As-is for this patch and the EGL series:
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
More information about the mesa-dev