[Mesa-dev] [PATCH 01/37] ABI-check: add a note that checking only T symbols is flacky

Emil Velikov emil.l.velikov at gmail.com
Thu Feb 23 17:13:28 UTC 2017


From: Emil Velikov <emil.velikov at collabora.com>

Note that all the symbols/ABI checks in tree do so :-\

Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
---
Mostly an RFC since the es*api code might be going soon.
---
 src/mapi/es2api/ABI-check | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/mapi/es2api/ABI-check b/src/mapi/es2api/ABI-check
index e0bf3c8314..e338408c7e 100755
--- a/src/mapi/es2api/ABI-check
+++ b/src/mapi/es2api/ABI-check
@@ -5,6 +5,10 @@
 # GL_EXT_multi_draw_arrays
 # GL_OES_EGL_image
 
+# FIXME: checking only for T symbols in incomplete/wrong.
+# At the same time checking for all brings platform specific symbols 
+# such as _edata and friends.
+
 FUNCS=$(nm -D --defined-only ${1-.libs/libGLESv2.so.2} | grep -o 'T gl.*' | cut -c 3- | while read func; do
 ( grep -q "^$func$" || echo $func )  <<EOF
 glActiveTexture
-- 
2.11.0



More information about the mesa-dev mailing list