[Mesa-dev] [PATCH 01/37] ABI-check: add a note that checking only T symbols is flacky

Matt Turner mattst88 at gmail.com
Thu Feb 23 17:34:34 UTC 2017


s/flacky/flakey/ in the title.

On Thu, Feb 23, 2017 at 9:13 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> Note that all the symbols/ABI checks in tree do so :-\
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Mostly an RFC since the es*api code might be going soon.

Tell me more :)

> ---
>  src/mapi/es2api/ABI-check | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/mapi/es2api/ABI-check b/src/mapi/es2api/ABI-check
> index e0bf3c8314..e338408c7e 100755
> --- a/src/mapi/es2api/ABI-check
> +++ b/src/mapi/es2api/ABI-check
> @@ -5,6 +5,10 @@
>  # GL_EXT_multi_draw_arrays
>  # GL_OES_EGL_image
>
> +# FIXME: checking only for T symbols in incomplete/wrong.

s/in/is/ ?

What's wrong with checking for T symbols? I don't know, and I think it
should be in the commit message.


More information about the mesa-dev mailing list