[Mesa-dev] [PATCH 35/37] bin/bugzilla_mesa.sh: rework the looping method

[Andreas Boll]

2017-02-23 18:14 GMT+01:00 Emil Velikov <emil.l.velikov at gmail.com>:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> We don't use DRYRUN (and no others scripts have one) so just drop it.
>
> This allows us to rework the loop to the more commonly used "git .... |
> while read foo; do ... done"
>
> That in itself gets rid of the only remaining bashism and we can toggle
> the shebang to /bin/sh.
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  bin/bugzilla_mesa.sh | 38 ++++++++++++--------------------------
>  1 file changed, 12 insertions(+), 26 deletions(-)
>
> diff --git a/bin/bugzilla_mesa.sh b/bin/bugzilla_mesa.sh
> index 49b9ce9c75..a8f5305844 100755
> --- a/bin/bugzilla_mesa.sh
> +++ b/bin/bugzilla_mesa.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>
>  # This script is used to generate the list of fixed bugs that
>  # appears in the release notes files, with HTML formatting.
> @@ -11,8 +11,6 @@
>  # $ bin/bugzilla_mesa.sh mesa-9.0.2..mesa-9.0.3
>  # $ bin/bugzilla_mesa.sh mesa-9.0.2..mesa-9.0.3 > bugfixes
>  # $ bin/bugzilla_mesa.sh mesa-9.0.2..mesa-9.0.3 | tee bugfixes
> -# $ DRYRUN=yes bin/bugzilla_mesa.sh mesa-9.0.2..mesa-9.0.3
> -# $ DRYRUN=yes bin/bugzilla_mesa.sh mesa-9.0.2..mesa-9.0.3 | wc -l

I guess it was only useful for offline usage and fast counting ;-)

Reviewed-by: Andreas Boll <andreas.boll.dev at gmail.com>

>
>
>  # regex pattern: trim before bug number
> @@ -21,29 +19,17 @@ trim_before='s/.*show_bug.cgi?id=\([0-9]*\).*/\1/'
>  # regex pattern: reconstruct the url
>  use_after='s,^,https://bugs.freedesktop.org/show_bug.cgi?id=,'
>
> -# extract fdo urls from commit log
> -urls=$(git log $* | grep 'bugs.freedesktop.org/show_bug' | sed -e $trim_before | sort -n -u | sed -e $use_after)
> -
> -# if DRYRUN is set to "yes", simply print the URLs and don't fetch the
> -# details from fdo bugzilla.
> -#DRYRUN=yes
> +echo "<ul>"
> +echo ""
>
> -if [ "x$DRYRUN" = xyes ]; then
> -       for i in $urls
> -       do
> -               echo $i
> -       done
> -else
> -       echo "<ul>"
> +# extract fdo urls from commit log
> +git log $* | grep 'bugs.freedesktop.org/show_bug' | sed -e $trim_before | sort -n -u | sed -e $use_after |\
> +while read url
> +do
> +       id=$(echo $url | cut -d'=' -f2)
> +       summary=$(wget --quiet -O - $url | grep -e '<title>.*</title>' | sed -e 's/ *<title>[0-9]\+ – \(.*\)<\/title>/\1/')
> +       echo "<li><a href=\"$url\">Bug $id</a> - $summary</li>"
>         echo ""
> +done
>
> -       for i in $urls
> -       do
> -               id=$(echo $i | cut -d'=' -f2)
> -               summary=$(wget --quiet -O - $i | grep -e '<title>.*</title>' | sed -e 's/ *<title>[0-9]\+ – \(.*\)<\/title>/\1/')
> -               echo "<li><a href=\"$i\">Bug $id</a> - $summary</li>"
> -               echo ""
> -       done
> -
> -       echo "</ul>"
> -fi
> +echo "</ul>"
> --
> 2.11.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev