[Mesa-dev] [PATCH 36/37] in/shortlog_mesa.sh: remove the final bashism

Andreas Boll andreas.boll.dev at gmail.com
Fri Feb 24 15:21:49 UTC 2017


Typo in commit summary (in/ -> bin/)

with that fixed:
Reviewed-by: Andreas Boll <andreas.boll.dev at gmail.com>

2017-02-23 18:14 GMT+01:00 Emil Velikov <emil.l.velikov at gmail.com>:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> Remove the typeset built-in and toggle to /bin/sh
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Sidenote: seems like there is something in the script which causes bash
> to trip in the odd occasion while zsh works like a charm.
>
> Namely "[rasterizer]" would become "z" while "[rasterizer foo]" will
> remain as-is.
>
> But that for another day ;-)
> ---
>  bin/shortlog_mesa.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bin/shortlog_mesa.sh b/bin/shortlog_mesa.sh
> index 2ba0815de7..c9a4297236 100755
> --- a/bin/shortlog_mesa.sh
> +++ b/bin/shortlog_mesa.sh
> @@ -1,4 +1,4 @@
> -#!/bin/bash
> +#!/bin/sh
>
>  # This script is used to generate the list of changes that
>  # appears in the release notes files, with HTML formatting.
> @@ -10,7 +10,7 @@
>  # $ bin/shortlog_mesa.sh mesa-9.0.2..mesa-9.0.3 | tee changes
>
>
> -typeset -i in_log=0
> +in_log=0
>
>  git shortlog $* | while read l
>  do
> --
> 2.11.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list