[Mesa-dev] [PATCH] configure.ac: check require_basic_egl only if egl enabled

[Emil Velikov]

On 24 February 2017 at 14:25, Leo Liu <leo.liu at amd.com> wrote:
> On 02/24/2017 09:07 AM, Emil Velikov wrote:
>>
>> On 23 February 2017 at 18:43, Leo Liu <leo.liu at amd.com> wrote:
>>>
>>> Otherwise the configuration fails when building independant libs
>>> like vdpau, vaapi or omx
>>>
>> I really should have spotted this usecase :-]
>>
>>> Signed-off-by: Leo Liu <leo.liu at amd.com>
>>> ---
>>>   configure.ac | 4 +++-
>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/configure.ac b/configure.ac
>>> index 44c7883..890a379 100644
>>> --- a/configure.ac
>>> +++ b/configure.ac
>>> @@ -2310,7 +2310,9 @@ if test -n "$with_gallium_drivers"; then
>>>               PKG_CHECK_MODULES([AMDGPU], [libdrm >=
>>> $LIBDRM_AMDGPU_REQUIRED libdrm_amdgpu >= $LIBDRM_AMDGPU_REQUIRED])
>>>               require_libdrm "radeonsi"
>>>               radeon_llvm_check $LLVM_REQUIRED_RADEONSI "radeonsi"
>>> -            require_basic_egl "radeonsi"
>>> +            if test "x$enable_egl" = xyes; then
>>> +                require_basic_egl "radeonsi"
>>> +            fi
>>
>> I'm split if we want to keep the check as-is or move within
>> require_basic_egl. In either case:
>>
>> Fixes: 1ac40173c2a ("configure.ac: simplify EGL requirements for
>> drivers dependent on EGL")
>
> Yes. This is regression point, I will add it to commit message.
> Also I would like to Cc: "17.0" <mesa-stable at lists.freedesktop.org> , where
> the issue was found.
>
Sure adding the mesa-stable tag is fine.

Say the offending commit is cherry-picked into branch A or B - with
the fixes tag, this will be nominated (props to [1]) to all applicable
branches.
it's quite a recent and fancy feature ;-)

-Emil
[1] bin/get-fixes-pick-list.sh