[Mesa-dev] [PATCH 2/4] glsl/tests/optimisation-test: ensure that compare_ir is available

[Emil Velikov]

On 24 February 2017 at 15:42, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> On Thursday, 2017-02-23 16:43:08 +0000, Emil Velikov wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>>
>> Bail out early if the script is not where we expect it to be.
>>
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>>  src/compiler/glsl/tests/optimization-test | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/src/compiler/glsl/tests/optimization-test b/src/compiler/glsl/tests/optimization-test
>> index 7ccbb4467d..ec0f09b125 100755
>> --- a/src/compiler/glsl/tests/optimization-test
>> +++ b/src/compiler/glsl/tests/optimization-test
>> @@ -27,6 +27,11 @@ for dir in tests/*/; do
>>      echo "$dir"
>>  done
>>
>> +if [ ! -e "$compare_ir" ]; then
>
> `-f` to make sure it's a file (not a dir)?
> Maybe even `-x` to make sure it can be executed (or just `-r` since it's
> actually read by $PYTHON2, not directly executed, so it doesn't *need*
> the executable bit).
>
No -x thank you. Barring any objections/other suggestions I'll use -r.

Thanks
Emil