[Mesa-dev] [PATCH v3 06/15] anv: Update "do not edit" comments with proper filename

Dylan Baker dylan at pnwbakers.com
Fri Feb 24 18:21:34 UTC 2017


This does two things, first it updates both the .h and the .c file to
have the same do not edit string. Second, it uses __file__ to ensure
that even if the file is moved or renamed that the name will be correct.

One thing to note is the use of '{{' and '}}' in the C template. This is
to instruct python to print a literal '{' and '}' respectively, rather
than treating the contents as a formatter specifier.

v3: - add this patch

Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
---
 src/intel/vulkan/anv_entrypoints_gen.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/intel/vulkan/anv_entrypoints_gen.py b/src/intel/vulkan/anv_entrypoints_gen.py
index 772f3e6..05a685d 100644
--- a/src/intel/vulkan/anv_entrypoints_gen.py
+++ b/src/intel/vulkan/anv_entrypoints_gen.py
@@ -23,6 +23,7 @@
 #
 
 import argparse
+import os
 import textwrap
 import xml.etree.ElementTree as et
 
@@ -131,7 +132,8 @@ def get_entrypoints_defines(doc):
 
 
 def gen_header(entrypoints):
-    print "/* This file generated from vk_gen.py, don't edit directly. */\n"
+    print "/* This file generated from {}, don't edit directly. */\n".format(
+        os.path.basename(__file__))
 
     print "struct anv_dispatch_table {"
     print "   union {"
@@ -188,21 +190,21 @@ def gen_code(entrypoints):
      * IN THE SOFTWARE.
      */
 
-    /* DO NOT EDIT! This is a generated file. */
+    /* This file generated from {}, don't edit directly. */
 
     #include "anv_private.h"
 
-    struct anv_entrypoint {
+    struct anv_entrypoint {{
        uint32_t name;
        uint32_t hash;
-    };
+    }};
 
     /* We use a big string constant to avoid lots of reloctions from the entry
      * point table to lots of little strings. The entries in the entry point table
      * store the index into this big string.
      */
 
-    static const char strings[] =""")
+    static const char strings[] =""".format(os.path.basename(__file__)))
 
     offsets = []
     i = 0
-- 
git-series 0.9.1


More information about the mesa-dev mailing list