[Mesa-dev] [PATCH] anv/image: Remove extra dependency on HiZ-specific variable

Jason Ekstrand jason at jlekstrand.net
Sat Feb 25 02:02:16 UTC 2017


seems reasonable

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Wed, Feb 22, 2017 at 4:33 PM, Nanley Chery <nanleychery at gmail.com> wrote:

> Depth buffers aren't allowed to be used as storage images.
>
> Fixes: 055ff2ec521 ("anv: Replace anv_image_has_hiz() with
> ISL_AUX_USAGE_HIZ")
> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/intel/vulkan/anv_image.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
> index e2f7ca340f..27bd0f212c 100644
> --- a/src/intel/vulkan/anv_image.c
> +++ b/src/intel/vulkan/anv_image.c
> @@ -595,7 +595,7 @@ anv_CreateImageView(VkDevice _device,
>                            .surf = &surface->isl,
>                            .view = &view,
>                            .aux_surf = &image->aux_surface.isl,
> -                          .aux_usage = surf_usage,
> +                          .aux_usage = image->aux_usage,
>                            .mocs = device->default_mocs);
>
>        if (isl_has_matching_typed_storage_image_format(&device->info,
> @@ -612,7 +612,7 @@ anv_CreateImageView(VkDevice _device,
>                               .surf = &surface->isl,
>                               .view = &view,
>                               .aux_surf = &image->aux_surface.isl,
> -                             .aux_usage = surf_usage,
> +                             .aux_usage = image->aux_usage,
>                               .mocs = device->default_mocs);
>        } else {
>           anv_fill_buffer_surface_state(device,
> iview->storage_surface_state,
> --
> 2.11.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170224/1d70d3dc/attachment.html>


More information about the mesa-dev mailing list