[Mesa-dev] [Mesa-stable] [PATCH v3 1/3] i965/fs: mark last DF uniform array element as 64 bit live one

Francisco Jerez currojerez at riseup.net
Sun Feb 26 04:36:25 UTC 2017


Samuel Iglesias Gonsálvez <siglesias at igalia.com> writes:

> This bug can make that we don't detect the end of a contiguous area
> correctly and push larger areas than the real ones.
>
> Signed-off-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> Cc: "17.0" <mesa-stable at lists.freedesktop.org>

Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>
> I am sending this mini-series to replace this patch from v2:
>
> "[PATCH v2 1/3] i965/fs: fix indirect load DF uniforms on BSW/BXT"
>
> The rest of parches of v2 are R-b and waiting for being pushed.
>
>  src/mesa/drivers/dri/i965/brw_fs.cpp | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp
> index c348bc7138..c713caa9b6 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp
> @@ -1952,6 +1952,9 @@ fs_visitor::assign_constant_locations()
>                 }
>              }
>              is_live[last] = true;
> +            if (type_sz(inst->src[i].type) == 8) {
> +                  is_live_64bit[last] = true;
> +            }
>           } else {
>              if (constant_nr >= 0 && constant_nr < (int) uniforms) {
>                 int regs_read = inst->components_read(i) *
> -- 
> 2.11.0
>
> _______________________________________________
> mesa-stable mailing list
> mesa-stable at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-stable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170225/b3e89bb6/attachment.sig>


More information about the mesa-dev mailing list