[Mesa-dev] [PATCH 8/8] r600/radeonsi: enableglsl/tgsion-diskcache

[Tobias Droste]

Mit freundlichen Grüßen
Am Freitag, 24. Februar 2017, 11:25:24 CET schrieb Marc Dietrich:
> Am Donnerstag, 23. Februar 2017, 11:50:07 CET schrieb Emil Velikov:
> > On 23 February 2017 at 10:20, Marc Dietrich <marvin24 at gmx.de> wrote:
> > > Am Donnerstag, 23. Februar 2017, 10:54:39 CET schrieb Michel Dänzer:
> > >> On 23/02/17 06:39 PM, Marc Dietrich wrote:
> > >> > Am Donnerstag, 23. Februar 2017, 04:10:23 CET schrieb Timothy Arceri:
> > >> >> I've pushed a fix for building with an old version of llvm.
> > >> >> Hopefully
> > >> >> this will resolve your problem.
> > >> > 
> > >> > I have a pretty current version of llvm (3.9.1), so the problem is
> > >> > not
> > >> > fixed by this patch :-) From the fact that it works for you and
> > >> > others,
> > >> > I
> > >> > guess it must be some distro packaging problem (suse thumbleweed
> > >> > here).
> > >> > llvm is using shared libs.
> > >> 
> > >> FWIW, this is broken packaging on SUSE's part — they need to build
> > >> LLVM
> > >> with LLVM_BUILD_LLVM_DYLIB=ON instead of BUILD_SHARED_LIBS=ON. The
> > >> latter is an unsupported developer only option. Please report this to
> > >> them.
> > > 
> > > does this mean that multiple shared libs are not supported by mesa? I
> > > read
> > > from the llvm website, that
> > > 
> > > "BUILD_SHARED_LIBS is only recommended for use by LLVM developers. If
> > > you
> > > want to build LLVM as a shared library, you should use the
> > > LLVM_BUILD_LLVM_DYLIB option."
> > > 
> > > I wonder why mesa tries to gather a list of required libs then (for
> > > static
> > > linking maybe?)
> > 
> > Yes, collecting the required libs is for static linking. Care to send
> > a patch which moves it within the correct section - 20-30 lines
> > further down ;-)
> 
> I can't test with static libs, but this patch here fixes it for me (tm)
> 
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2297,6 +2297,11 @@ if test -n "$with_gallium_drivers"; then
>              HAVE_GALLIUM_R600=yes
>              PKG_CHECK_MODULES([RADEON], [libdrm >= $LIBDRM_RADEON_REQUIRED
> libdrm_radeon >= $LIBDRM_RADEON_REQUIRED])
>              require_libdrm "r600"
> +            if test "x$enable_llvm" = xyes; then
> +                radeon_llvm_check $LLVM_REQUIRED_R600 "r600"
> +
> +                llvm_add_component "amdgpuinfo" "r600"
> +            fi
>              if test "x$enable_opencl" = xyes; then
>                  radeon_llvm_check $LLVM_REQUIRED_R600 "r600"

Could you put the "llvm_add_component "amdgpuinfo" "r600"" line into the 
function "radeon_llvm_check()" and send the result as a git patch?