[Mesa-dev] [PATCH] r600: add amdgpuinfo to the llvm required module list

[Emil Velikov]

On 27 February 2017 at 11:54, Marc Dietrich <marvin24 at gmx.de> wrote:
> This fixes the build when mesa is build against a static libllvm and
> consolidates the module collection a bit.
>
> Signed-off-by: Marc Dietrich <marvin24 at gmx.de>
> ---
>  configure.ac | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 890a37999c..adc81260a9 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1005,6 +1005,8 @@ radeon_llvm_check() {
>      llvm_add_target $amdgpu_llvm_target_name $2
>
>      llvm_add_default_components $2
> +    llvm_add_component "amdgpuinfo" "r600"
Afaict (just did a quick check against a shared llvm 3.9 and static
llvm 3.8) the llvm_add_target adds any amdgpu components, so this
should not be needed... unless the llvm build is broken.

Or in other words:
 - which llvm version are you using
 - if using llvm 3.9 or later and the default build is "shared" (see
llvm-config --shared-mode) you will need "--link-static" alongside the
"--libs"
 - the output of llvm-config --libs amdgpu should include the amdgpuinfo part ?

Care to send a patch which uses --link{static/shared] for 3.9+ ? For
earlier LLVM versions we might need to stick with the current code...
which shouldn't use LLVM_COMPONENTS in the static case (another
patch).

Thanks
Emil