[Mesa-dev] [PATCH] nir: Delete unused arg in get_iteration

[Eric Engestrom]

On Monday, 2017-02-27 14:22:55 +0000, Elie Tournier wrote:
> Some1 to review this patch?

Reviewed and pushed, thanks :)

> 
> On 21/02/17 16:15, Elie Tournier wrote:
> > nir_const_value is not needed in get_iteration
> Oops typo:
> nir_alu_instr is not needed in get_iteration

... and I only just saw this now :(

> > Signed-off-by: Elie Tournier <tournier.elie at gmail.com>
> > ---
> > I don't have the git access. Please push it for me.
> > BR,
> > Elie
> > ---
> >   src/compiler/nir/nir_loop_analyze.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/src/compiler/nir/nir_loop_analyze.c b/src/compiler/nir/nir_loop_analyze.c
> > index a5f464a45d..6afad9e603 100644
> > --- a/src/compiler/nir/nir_loop_analyze.c
> > +++ b/src/compiler/nir/nir_loop_analyze.c
> > @@ -359,7 +359,7 @@ find_loop_terminators(loop_info_state *state)
> >   static int32_t
> >   get_iteration(nir_op cond_op, nir_const_value *initial, nir_const_value *step,
> > -              nir_const_value *limit, nir_alu_instr *alu)
> > +              nir_const_value *limit)
> >   {
> >      int32_t iter;
> > @@ -490,7 +490,7 @@ calculate_iterations(nir_const_value *initial, nir_const_value *step,
> >         trip_offset = 1;
> >      }
> > -   int iter_int = get_iteration(cond_alu->op, initial, step, limit, alu);
> > +   int iter_int = get_iteration(cond_alu->op, initial, step, limit);
> >      /* If iter_int is negative the loop is ill-formed or is the conditional is
> >       * unsigned with a huge iteration count so don't bother going any further.
> 
> -- 
> Elie Tournier
> <elie.tournier at collabora.co.uk>
> Collabora Ltd.
>