[Mesa-dev] [PATCH 0/6] r600g: r600_shader.c small cleanups

Dave Airlie airlied at gmail.com
Tue Feb 28 02:44:20 UTC 2017

On 28 February 2017 at 12:42, Constantine Charlamov <Hi-Angel at yandex.ru> wrote:
> On 28.02.2017 05:19, Dave Airlie wrote:
>> On 27 February 2017 at 06:31, Constantine Charlamov <Hi-Angel at yandex.ru> wrote: >> Initially I was trying to implement for r600 optimization like in the d633e23192ef17207f4a6acd3009da3126aab395 commit for radeonsi, but failed because I need to learn some more about GPUs internals. For another time. Anyway, accidentally it turned into a small cleanup of r600_shader.c, here it
> is. >> >> Hi-Angel (6): >>   Get rid of trailing whitespace (trivial) >>   Rename i→chan_index >>   Replace bit-shifts and cycles with helpers from tgsi_exec.h >>   Rename tgsi_last_instruction → tgsi_last_channel >>   Get rid of tgsi_last_channel() wherever possible, rename lasti → >>     last_chan
>>>   Remove redudant comparisons > > > Have they passed a complete piglit run without regressions? > > Dave.
> Hmm I don't know. Is there some specific test I should be running? I indeed tried
>     ./piglit run shader results/shader --all-concurrent

piglit run -c tests/gpu.py results/gpu

I'm not sure how long an r600 run takes, I haven't ran it in a while,
but any patches that clean stuff up should probably make sure they
don't cause regressions on the way.


More information about the mesa-dev mailing list