[Mesa-dev] [PATCH] r600: link against common ac library.

[Timothy Arceri]

On 28/02/17 16:35, Dieter Nützel wrote:
> Ugh,
>
> Timothy's commit (4d0d813) was NOT enough,

Are you sure? I can build OpenCL and nine without this patch. What do 
you mean by it was not enough? Did you get a build error? or something else?


> then
> with THIS I get the below and after reverting THIS I'm set...
>
> [-]
>
> make[1]: Entering directory '/opt/mesa'
> make[1]: Nothing to be done for 'all-am'.
> make[1]: Leaving directory '/opt/mesa'
>
> -Dieter
>
> Am 28.02.2017 06:19, schrieb Dieter Nützel:
>> This one fixes --enable-opencl (apart from Timothy's 'fix' commit), but
>> NOT nine...
>>
>> Making all in targets/d3dadapter9
>> make[4]: Entering directory '/opt/mesa/src/gallium/targets/d3dadapter9'
>>   CXXLD    d3dadapter9.la
>> ../../../../src/amd/common/.libs/libamd_common.a(common_libamd_common_la-ac_binary.o):
>>
>> In function `ac_elf_read':
>> /opt/mesa/src/amd/common/ac_binary.c:114: multiple definition of
>> `ac_elf_read'
>> ../../../../src/amd/common/.libs/libamd_common.a(common_libamd_common_la-ac_binary.o):/opt/mesa/src/amd/common/ac_binary.c:114:
>>
>> first defined here
>> ../../../../src/amd/common/.libs/libamd_common.a(common_libamd_common_la-ac_binary.o):
>>
>> In function `ac_shader_binary_config_start':
>> /opt/mesa/src/amd/common/ac_binary.c:196: multiple definition of
>> `ac_shader_binary_config_start'
>> ../../../../src/amd/common/.libs/libamd_common.a(common_libamd_common_la-ac_binary.o):/opt/mesa/src/amd/common/ac_binary.c:196:
>>
>> first defined here
>> ../../../../src/amd/common/.libs/libamd_common.a(common_libamd_common_la-ac_binary.o):
>>
>> In function `ac_shader_binary_read_config':
>> /opt/mesa/src/amd/common/ac_binary.c:216: multiple definition of
>> `ac_shader_binary_read_config'
>> ../../../../src/amd/common/.libs/libamd_common.a(common_libamd_common_la-ac_binary.o):/opt/mesa/src/amd/common/ac_binary.c:216:
>>
>> first defined here
>> ../../../../src/amd/common/.libs/libamd_common.a(common_libamd_common_la-ac_llvm_build.o):
>>
>> In function `ac_llvm_context_init':
>>
>> [-] And so on...
>>
>> I'm using:
>> ./autogen.sh --prefix=/usr/local --with-dri-drivers=""
>> --with-gallium-drivers=r600,radeonsi,swrast --with-egl-platforms=drm
>> --enable-nine --enable-texture-float --enable-opencl
>> --with-vulkan-drivers=radeon
>>
>> Thanks,
>> Dieter
>>
>> Am 28.02.2017 06:05, schrieb Dave Airlie:
>>> From: Dave Airlie <airlied at redhat.com>
>>>
>>> This should fix the build.
>>>
>>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>>> ---
>>>  src/gallium/drivers/r600/Automake.inc | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/gallium/drivers/r600/Automake.inc
>>> b/src/gallium/drivers/r600/Automake.inc
>>> index 914eea3..0355455 100644
>>> --- a/src/gallium/drivers/r600/Automake.inc
>>> +++ b/src/gallium/drivers/r600/Automake.inc
>>> @@ -4,6 +4,7 @@ TARGET_DRIVERS += r600
>>>  TARGET_CPPFLAGS += -DGALLIUM_R600
>>>  TARGET_LIB_DEPS += \
>>>      $(top_builddir)/src/gallium/drivers/r600/libr600.la \
>>> +    $(top_builddir)/src/amd/common/libamd_common.la \
>>>      $(RADEON_LIBS) \
>>>      $(LIBDRM_LIBS)
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev