[Mesa-dev] [PATCH 22/37] gallium/tests: remove execute bit from TGSI shader - vert-uadd.sh

Jose Fonseca jfonseca at vmware.com
Tue Feb 28 22:10:09 UTC 2017

On 23/02/17 17:13, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> Just like the the dozens of other shaders, the file is parsed by
> separate tool and not executed.
> Cc: José Fonseca <jfonseca at vmware.com>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
> ---
> Jose, please double-check since I've got no idea how there are used.
> Out of curiosity - do you guys still use these ? Afaict TGSI has evolved
> since those are added yet new opcodes are not covered. Perhaps they
> should ?

These simple tests are useful when bring up a new gallium driver, and 
only for that.  (As for complete gallium drivers test suites that 
operate OpenGL/Direct3D API are more interesting)

We haven't started a new gallium driver in ages, therefore we haven't 
used it ourselves in ages too.

> ---
>  src/gallium/tests/graw/vertex-shader/vert-uadd.sh | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100755 => 100644 src/gallium/tests/graw/vertex-shader/vert-uadd.sh
> diff --git a/src/gallium/tests/graw/vertex-shader/vert-uadd.sh b/src/gallium/tests/graw/vertex-shader/vert-uadd.sh
> old mode 100755
> new mode 100644

Yes, this is indeed not a shell file.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>

More information about the mesa-dev mailing list