[Mesa-dev] [PATCH 15/19] mesa: hook up UUID queries for driver and device

[Michel Dänzer]

On 01/07/17 09:58 AM, Andres Rodriguez wrote:
> On 2017-06-30 07:21 PM, Jason Ekstrand wrote:
>> On June 30, 2017 4:04:31 PM Andres Rodriguez <andresx7 at gmail.com> wrote:
>>
>>> diff --git a/src/mesa/main/version.c b/src/mesa/main/version.c
>>> index 34f8bbb..402fc01 100644
>>> --- a/src/mesa/main/version.c
>>> +++ b/src/mesa/main/version.c
>>> @@ -635,3 +635,19 @@ _mesa_compute_version(struct gl_context *ctx)
>>>        break;
>>>     }
>>>  }
>>> +
>>> +
>>> +void
>>> +_mesa_get_driver_uuid(struct gl_context *ctx, GLint *uuid)
>>> +{
>>> +   uuid[0] = 'M';
>>> +   uuid[1] = 'E';
>>> +   uuid[2] = 'S';
>>> +   uuid[4] = 'A';
>>
>> This isn't right.  The driver uuid is supposed to encompass not only
>> the driver but also a version.  This is used to ensure that all of the
>> magic between GL and Vulkan will "just work".  That magic includes
>> whatever heuristics are used to choose image layout.  Since these may
>> change from version to version, this should be some sort of version
>> number and probably needs to be provided by the actual driver.
>>
> 
> This is something I've been on the fence about for a while, mostly
> because the vulkan and gl driver for mesa come out of the same source
> base.

In addition to the issues raised by Jason, radv isn't the only Vulkan
driver for AMD GPUs.


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer