[Mesa-dev] [PATCH v2 01/73] nir: add nir_instr_rewrite_deref

Jason Ekstrand jason at jlekstrand.net
Wed Jul 5 19:10:10 UTC 2017


I like it

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Wed, Jul 5, 2017 at 3:47 AM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:

> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>
> Allows modifying a texture instruction's texture and sampler derefs.
> ---
>  src/compiler/nir/nir.c | 13 +++++++++++++
>  src/compiler/nir/nir.h |  2 ++
>  2 files changed, 15 insertions(+)
>
> diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c
> index 491b908..f81f4ee 100644
> --- a/src/compiler/nir/nir.c
> +++ b/src/compiler/nir/nir.c
> @@ -1502,20 +1502,33 @@ nir_instr_rewrite_dest(nir_instr *instr, nir_dest
> *dest, nir_dest new_dest)
>
>     nir_dest_copy(dest, &new_dest, instr);
>
>     dest->reg.parent_instr = instr;
>     list_addtail(&dest->reg.def_link, &new_dest.reg.reg->defs);
>
>     if (dest->reg.indirect)
>        src_add_all_uses(dest->reg.indirect, instr, NULL);
>  }
>
> +void
> +nir_instr_rewrite_deref(nir_instr *instr, nir_deref_var **deref,
> +                        nir_deref_var *new_deref)
> +{
> +   if (*deref)
> +      visit_deref_src(*deref, remove_use_cb, NULL);
> +
> +   *deref = new_deref;
> +
> +   if (*deref)
> +      visit_deref_src(*deref, add_use_cb, instr);
> +}
> +
>  /* note: does *not* take ownership of 'name' */
>  void
>  nir_ssa_def_init(nir_instr *instr, nir_ssa_def *def,
>                   unsigned num_components,
>                   unsigned bit_size, const char *name)
>  {
>     def->name = ralloc_strdup(instr, name);
>     def->parent_instr = instr;
>     list_inithead(&def->uses);
>     list_inithead(&def->if_uses);
> diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
> index c41b0dc..1ca98f8 100644
> --- a/src/compiler/nir/nir.h
> +++ b/src/compiler/nir/nir.h
> @@ -2199,20 +2199,22 @@ bool nir_foreach_dest(nir_instr *instr,
> nir_foreach_dest_cb cb, void *state);
>  bool nir_foreach_src(nir_instr *instr, nir_foreach_src_cb cb, void
> *state);
>
>  nir_const_value *nir_src_as_const_value(nir_src src);
>  bool nir_src_is_dynamically_uniform(nir_src src);
>  bool nir_srcs_equal(nir_src src1, nir_src src2);
>  void nir_instr_rewrite_src(nir_instr *instr, nir_src *src, nir_src
> new_src);
>  void nir_instr_move_src(nir_instr *dest_instr, nir_src *dest, nir_src
> *src);
>  void nir_if_rewrite_condition(nir_if *if_stmt, nir_src new_src);
>  void nir_instr_rewrite_dest(nir_instr *instr, nir_dest *dest,
>                              nir_dest new_dest);
> +void nir_instr_rewrite_deref(nir_instr *instr, nir_deref_var **deref,
> +                             nir_deref_var *new_deref);
>
>  void nir_ssa_dest_init(nir_instr *instr, nir_dest *dest,
>                         unsigned num_components, unsigned bit_size,
>                         const char *name);
>  void nir_ssa_def_init(nir_instr *instr, nir_ssa_def *def,
>                        unsigned num_components, unsigned bit_size,
>                        const char *name);
>  void nir_ssa_def_rewrite_uses(nir_ssa_def *def, nir_src new_src);
>  void nir_ssa_def_rewrite_uses_after(nir_ssa_def *def, nir_src new_src,
>                                      nir_instr *after_me);
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170705/38a14fca/attachment.html>


More information about the mesa-dev mailing list