[Mesa-dev] [PATCH] radv/ac: drop setting xnack

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu Jul 6 22:19:34 UTC 2017


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Fri, Jul 7, 2017 at 12:10 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Since radv uses compute rings and we can't know when we are setting
> up the shaders what ring they are to be used on, we should just use
> the default xnack setting. This may be suboptimal in some places,
> but if we hit a problem, we likely should try and address this
> between llvm and mesa.
>
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/common/ac_llvm_util.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/amd/common/ac_llvm_util.c b/src/amd/common/ac_llvm_util.c
> index d14057f..ea752e0 100644
> --- a/src/amd/common/ac_llvm_util.c
> +++ b/src/amd/common/ac_llvm_util.c
> @@ -126,8 +126,7 @@ LLVMTargetMachineRef ac_create_target_machine(enum radeon_family family, enum ac
>         LLVMTargetRef target = ac_get_llvm_target(triple);
>
>         snprintf(features, sizeof(features),
> -                "+DumpCode,+vgpr-spilling,-fp32-denormals%s%s",
> -                family >= CHIP_VEGA10 ? ",+xnack" : ",-xnack",
> +                "+DumpCode,+vgpr-spilling,-fp32-denormals%s",
>                  tm_options & AC_TM_SISCHED ? ",+si-scheduler" : "");
>
>         LLVMTargetMachineRef tm = LLVMCreateTargetMachine(
> --
> 2.9.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list