[Mesa-dev] [PATCH 2/6] nir/lower_io_to_temporaries: don't set compact on shadow vars

[Jason Ekstrand]

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Thu, Jul 6, 2017 at 12:48 PM, Connor Abbott <connora at valvesoftware.com>
wrote:

> From: Connor Abbott <cwabbott0 at gmail.com>
>
> The compact flag doesn't make sense on local variables, since the
> packing on them is up to the driver. This fixes nir_validate assertions
> in some cases, particularly when lower_io_to_temporaries is used on
> per-vertex inputs/outputs.
> ---
>  src/compiler/nir/nir_lower_io_to_temporaries.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/compiler/nir/nir_lower_io_to_temporaries.c
> b/src/compiler/nir/nir_lower_io_to_temporaries.c
> index 6031bbd..d2df14e 100644
> --- a/src/compiler/nir/nir_lower_io_to_temporaries.c
> +++ b/src/compiler/nir/nir_lower_io_to_temporaries.c
> @@ -141,6 +141,7 @@ create_shadow_temp(struct lower_io_state *state,
> nir_variable *var)
>     temp->data.mode = nir_var_global;
>     temp->data.read_only = false;
>     temp->data.fb_fetch_output = false;
> +   temp->data.compact = false;
>
>     return nvar;
>  }
> --
> 2.9.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170706/39a0ab8f/attachment.html>