[Mesa-dev] [PATCH 3/6] ac/nir: rewrite local variable handling

Connor Abbott cwabbott0 at gmail.com
Fri Jul 7 02:02:37 UTC 2017


On Thu, Jul 6, 2017 at 6:36 PM, Matt Arsenault <arsenm2 at gmail.com> wrote:
>
> On Jul 6, 2017, at 18:31, Connor Abbott <cwabbott0 at gmail.com> wrote:
>
> After looking into it some more, I think LLVM won't promote allocas to
> registers at all when there are non-constant indices in the mix, and
> fixing it seems kinda involved. I guess a better solution for now
>
>
> AMDGPUPromoteAlloca does this, but it doesn’t happen very often

Could we just bump the heuristic on maximum size there to match
radeonsi? That way we wouldn't need to have these heuristics in
radeonsi and radv. As-is, we're second-guessing the backend.


More information about the mesa-dev mailing list