[Mesa-dev] [PATCH] etnaviv: fix refcnt initialization in etna_screen

[Emil Velikov]

On 7 July 2017 at 09:09, Lucas Stach <l.stach at pengutronix.de> wrote:
> Am Donnerstag, den 06.07.2017, 23:18 +0200 schrieb Aleksander Morgado:
>> Despite being a member of the etna_screen struct, 'refcnt' is used by
>> the winsys-specific logic to track the reference count of the object
>> managed in a hash table. When the count reaches zero, the pipe screen
>> is removed from the table and destroyed.
>>
>> Fix the logic by initializing the refcnt to 1 when screen created.
>> This initialization is done in etna_screen_create(), to follow the
>> same logic as in freedreno and virgl.
>
> Urgh, nice (for whatever value of nice) find. I'll push this with stable
> tags added in a moment.
>
It should land in stable indeed. Thanks Lucas.

Very quick skim shows that other drivers don't have this bug, yet I
wonder if we cannot get a volunteer to re-spin RobH refcount
series[1].
There were some comments but nothing serious IMHO.

Also, welcome to Mesa Aleksander!
Emil

[1] https://patchwork.freedesktop.org/series/8855/