[Mesa-dev] [PATCH] st/dri: add 32-bit RGBX/RGBA formats

[Marek Olšák]

On Thu, Jul 6, 2017 at 12:22 AM, Chad Versace <chadversary at chromium.org> wrote:
> On Sat 01 Jul 2017, Marek Olšák wrote:
>> Hi Rob,
>>
>> It would be better to have a flag passed from libEGL to st/dri saying
>> that it's OK to expose those formats. I wouldn't like to have GLX
>> visuals that are unusable in practice because X doesn't support that
>> component ordering.
>
> At least on Intel, the equivalent patch exposed no new GLX visuals. When I
> investigated with gdb, Mesa's GLX code matches internal visual to X server
> visuals by examining just the bitsize of each channel, and chooses the first
> matching internal visual as the winner, ignoring all other visuals. As long as
> the BGRA and BGRX internal visuals precede the RGBA and RGBX ones, then the
> user never sees them.

OK, you've convinced me:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek