[Mesa-dev] [PATCH 1/2] Revert "intel/isl: Only create a CCS buffer if the image supports rendering"

Nanley Chery nanleychery at gmail.com
Fri Jul 7 21:30:45 UTC 2017


On Thu, Jul 06, 2017 at 01:11:27PM -0700, Nanley Chery wrote:
> This reverts commit 8aaa13467dc289d35dc7900ab9fab9a7689c4178, which was
> based on an incorrect assumption. Unlike the restriction placed on image
> views in the Vulkan API, OpenGL allows you to render to texture views
> whose formats differ from the originals.
> 
> Bugzilla: https://bugzilla.freedesktop.org/show_bug.cgi?id=101677
> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>  src/intel/isl/isl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Pushed.

> diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
> index bbbdb19df2..ba56d86c17 100644
> --- a/src/intel/isl/isl.c
> +++ b/src/intel/isl/isl.c
> @@ -1699,7 +1699,7 @@ isl_surf_get_ccs_surf(const struct isl_device *dev,
>     if (ISL_DEV_GEN(dev) <= 8 && surf->dim != ISL_SURF_DIM_2D)
>        return false;
>  
> -   if (!isl_format_supports_rendering(dev->info, surf->format))
> +   if (isl_format_is_compressed(surf->format))
>        return false;
>  
>     /* TODO: More conditions where it can fail. */
> -- 
> 2.13.2
> 


More information about the mesa-dev mailing list