[Mesa-dev] [PATCH 1/2] egl/android: remove HAL_PIXEL_FORMAT_BGRA_8888 support

[Rob Herring]

On Tue, Jul 11, 2017 at 8:27 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> As said in the EGL_KHR_platform_android extensions
>
>     For each EGLConfig that belongs to the Android platform, the
>     EGL_NATIVE_VISUAL_ID attribute is an Android window format, such as
>     WINDOW_FORMAT_RGBA_8888.
>
> Although it should be applicable overall.
>
> Even though we use HAL_PIXEL_FORMAT here, those are numerically
> identical to the  WINDOW_FORMAT_ and AHARDWAREBUFFER_FORMAT_ ones.
>
> Barring the said format of course. That one is only listed in HAL.
>
> Keep in mind that even if we try to use the said format, you'll get
> caught by droid_create_surface(). The function compares the format of
> the underlying window, against the NATIVE_VISUAL_ID of the config.
>
> Unfortunatelly it only prints a warning, rather than error out, likely
> leading to visual corruption.
>
> While SDL will even call ANativeWindow_setBuffersGeometry() with the
> wrong format, and conviniently ignore the [expected] failure.
>
> Cc: mesa-stable at lists.freedesktop.org
> Cc: Chad Versace <chadversary at google.com>
> Cc: Tomasz Figa <tfiga at chromium.org>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> I'm about 99.99% sure the above is correct, but I haven't tested it.

Isn't this going to break if there's no driver support for RGBA/RGBX
which is the case for stable (and master for gallium drvs).

Rob