[Mesa-dev] [PATCH] gallium/util: remove unused util_{begin, end}_pipestat_query() helpers

Marek Olšák maraeo at gmail.com
Tue Jul 11 22:41:02 UTC 2017


I'd like to keep these for debugging.

Marek

On Thu, Jul 6, 2017 at 6:43 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/auxiliary/util/u_helpers.c | 50 ----------------------------------
>  src/gallium/auxiliary/util/u_helpers.h |  7 -----
>  2 files changed, 57 deletions(-)
>
> diff --git a/src/gallium/auxiliary/util/u_helpers.c b/src/gallium/auxiliary/util/u_helpers.c
> index e0feade3ac..6946a1ada9 100644
> --- a/src/gallium/auxiliary/util/u_helpers.c
> +++ b/src/gallium/auxiliary/util/u_helpers.c
> @@ -117,53 +117,3 @@ util_upload_index_buffer(struct pipe_context *pipe,
>     *out_offset -= start_offset;
>     return *out_buffer != NULL;
>  }
> -
> -struct pipe_query *
> -util_begin_pipestat_query(struct pipe_context *ctx)
> -{
> -   struct pipe_query *q =
> -      ctx->create_query(ctx, PIPE_QUERY_PIPELINE_STATISTICS, 0);
> -   if (!q)
> -      return NULL;
> -
> -   ctx->begin_query(ctx, q);
> -   return q;
> -}
> -
> -void
> -util_end_pipestat_query(struct pipe_context *ctx, struct pipe_query *q,
> -                        FILE *f)
> -{
> -   static unsigned counter;
> -   struct pipe_query_data_pipeline_statistics stats;
> -
> -   ctx->end_query(ctx, q);
> -   ctx->get_query_result(ctx, q, true, (void*)&stats);
> -   ctx->destroy_query(ctx, q);
> -
> -   fprintf(f,
> -           "Draw call %u:\n"
> -           "    ia_vertices    = %"PRIu64"\n"
> -           "    ia_primitives  = %"PRIu64"\n"
> -           "    vs_invocations = %"PRIu64"\n"
> -           "    gs_invocations = %"PRIu64"\n"
> -           "    gs_primitives  = %"PRIu64"\n"
> -           "    c_invocations  = %"PRIu64"\n"
> -           "    c_primitives   = %"PRIu64"\n"
> -           "    ps_invocations = %"PRIu64"\n"
> -           "    hs_invocations = %"PRIu64"\n"
> -           "    ds_invocations = %"PRIu64"\n"
> -           "    cs_invocations = %"PRIu64"\n",
> -           p_atomic_inc_return(&counter),
> -           stats.ia_vertices,
> -           stats.ia_primitives,
> -           stats.vs_invocations,
> -           stats.gs_invocations,
> -           stats.gs_primitives,
> -           stats.c_invocations,
> -           stats.c_primitives,
> -           stats.ps_invocations,
> -           stats.hs_invocations,
> -           stats.ds_invocations,
> -           stats.cs_invocations);
> -}
> diff --git a/src/gallium/auxiliary/util/u_helpers.h b/src/gallium/auxiliary/util/u_helpers.h
> index ab970d791b..7fed144d81 100644
> --- a/src/gallium/auxiliary/util/u_helpers.h
> +++ b/src/gallium/auxiliary/util/u_helpers.h
> @@ -50,13 +50,6 @@ bool util_upload_index_buffer(struct pipe_context *pipe,
>                                struct pipe_resource **out_buffer,
>                                unsigned *out_offset);
>
> -struct pipe_query *
> -util_begin_pipestat_query(struct pipe_context *ctx);
> -
> -void
> -util_end_pipestat_query(struct pipe_context *ctx, struct pipe_query *q,
> -                        FILE *f);
> -
>  #ifdef __cplusplus
>  }
>  #endif
> --
> 2.13.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list