[Mesa-dev] [PATCH 3/4] st/mesa: add support for KHR_no_error flag

Eric Engestrom eric.engestrom at imgtec.com
Wed Jul 12 16:47:21 UTC 2017


On Wednesday, 2017-07-12 17:58:56 +0200, Grigori Goronzy wrote:
> On 2017-07-12 15:08, Emil Velikov wrote:
> > On 11 July 2017 at 23:26, Grigori Goronzy <greg at chown.ath.cx> wrote:
> > > Add a new context flag and plumb it through the various layers of the
> > > context creation code to set up dispatch tables for the no-error mode.
> > > ---
> > >  src/gallium/include/state_tracker/st_api.h   |  1 +
> > >  src/gallium/state_trackers/dri/dri_context.c |  3 +++
> > >  src/mesa/state_tracker/st_context.c          | 10 +++++++---
> > >  src/mesa/state_tracker/st_context.h          |  3 ++-
> > >  src/mesa/state_tracker/st_manager.c          |  6 +++++-
> > >  5 files changed, 18 insertions(+), 5 deletions(-)
> > > 
> > I think this should come before the enablement patch... although
> > looking at Issue #6 we may be fine as-is.
> > 
> 
> What's issue #6?

Issue #6 in the spec [1]:

> (6) Should creating a context fail if the context created context does not
> support a no error mode?
> 
> RESOLVED: No.  Expect context creation to succeed even if the implementation
> can't honor the request for a no error context. This reduces the number of
> reasons creating a context can fail and seems to be a more forward looking
> resolution considering context flags allow GL apps to query what context
> flags are set.

In other words, it is legal to advertise the extension before you
actually support it, however counter-intuitive this may be.

[1] https://www.khronos.org/registry/EGL/extensions/KHR/EGL_KHR_create_context_no_error.txt


More information about the mesa-dev mailing list