[Mesa-dev] [PATCH v2 27/27] i965: Advertise the CCS modifier

[Chad Versace]

On Thu 29 Jun 2017, Jason Ekstrand wrote:
> From: Ben Widawsky <ben at bwidawsk.net>
> 
> v2: Rename modifier to be more smart (Jason)
> 
> FINISHME: Use the kernel's final choice for the fb modifier
> 
> bwidawsk at norris2:~/intel-gfx/kmscube (modifiers $) ~/scripts/measure_bandwidth.sh ./kmscube none
> Read bandwidth: 603.91 MiB/s
> Write bandwidth: 615.28 MiB/s
> bwidawsk at norris2:~/intel-gfx/kmscube (modifiers $) ~/scripts/measure_bandwidth.sh ./kmscube ytile
> Read bandwidth: 571.13 MiB/s
> Write bandwidth: 555.51 MiB/s
> bwidawsk at norris2:~/intel-gfx/kmscube (modifiers $) ~/scripts/measure_bandwidth.sh ./kmscube ccs
> Read bandwidth: 259.34 MiB/s
> Write bandwidth: 337.83 MiB/s
> 
> v2: Move all references to the new fourcc code(s) to this patch.
> v3: Rebase, remove Yf_CCS (Daniel)
> 
> Cc: Jason Ekstrand <jason at jlekstrand.net>
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> Acked-by: Daniel Stone <daniels at collabora.com>
> ---
>  src/mesa/drivers/dri/i965/intel_screen.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c
> index 323cd5a..1729f6a 100644
> --- a/src/mesa/drivers/dri/i965/intel_screen.c
> +++ b/src/mesa/drivers/dri/i965/intel_screen.c
> @@ -51,6 +51,10 @@
>  #define DRM_FORMAT_MOD_LINEAR 0
>  #endif
>  
> +#ifndef I915_FORMAT_MOD_Y_TILED_CCS
> +#define I915_FORMAT_MOD_Y_TILED_CCS fourcc_mod_code(INTEL, 4)
> +#endif

Due to this #define, the two instances in this patch of

    /* I915_FORMAT_MOD_Y_TILED_CCS */ fourcc_mod_code(INTEL, 4)

can get cleaned up. With that, this is
Reviewed-by: Chad Versace <chadversary at chromium.org>