[Mesa-dev] [PATCH v2 21/27] i965: Support images with aux buffers

[Jason Ekstrand]

On Wed, Jul 12, 2017 at 10:22 AM, Chad Versace <chadversary at chromium.org>
wrote:

> On Thu 29 Jun 2017, Jason Ekstrand wrote:
> > From: Ben Widawsky <ben at bwidawsk.net>
> >
> > Previously images did not support any auxiliary compression surfaces
> > (CCS, MCS, or HiZ).  That's about to change.  This patch just adds the
> > fields to __DRIimageRec to make auxiliary surfaces possible.
> >
> > v2 (Jason Ekstrand):
> >  - Add an aux_pitch parameter as well as aux_offset
> >
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> > Acked-by: Daniel Stone <daniels at collabora.com>
> > Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> > ---
> >  src/mesa/drivers/dri/i965/intel_image.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/src/mesa/drivers/dri/i965/intel_image.h
> b/src/mesa/drivers/dri/i965/intel_image.h
> > index cf06105..5ac5c31 100644
> > --- a/src/mesa/drivers/dri/i965/intel_image.h
> > +++ b/src/mesa/drivers/dri/i965/intel_image.h
> > @@ -92,6 +92,12 @@ struct __DRIimageRec {
> >     /** The image was created with EGL_EXT_image_dma_buf_import. */
> >     bool dma_buf_imported;
> >
> > +   /** Offset of the auxiliary compression surface in the bo. */
> > +   uint32_t aux_offset;
>
> Just to clarify... is aux_offset relative to the bo's base address, or
> relative to __DRIimageRec::offset?
>

The BO.  Aux is only supported for "simple" surfaces so
__DRIimageRec::offset should be 0.  Unless, of course, I have no idea what
I'm doing which is entirely possible. :/

--Jason
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170712/f624dacb/attachment.html>