[Mesa-dev] [PATCH] radv: Fix possible invalid free of dynamic descriptors

[Bas Nieuwenhuizen]

Thanks, pushed.

On Wed, Jul 12, 2017 at 12:14 PM, Alex Smith
<asmith at feralinteractive.com> wrote:
> This free was left in after dynamic descriptors were changed to not be
> allocated separately from the descriptor set, and can cause a crash.
>
> Fixes: 39644fa40a3 ("radv: Don't allocate dynamic descriptors separately")
> Signed-off-by: Alex Smith <asmith at feralinteractive.com>
> ---
>  src/amd/vulkan/radv_descriptor_set.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c
> index b4a78aa..7cee9d4 100644
> --- a/src/amd/vulkan/radv_descriptor_set.c
> +++ b/src/amd/vulkan/radv_descriptor_set.c
> @@ -317,7 +317,6 @@ radv_descriptor_set_create(struct radv_device *device,
>                         }
>
>                         if (pool->size - offset < layout_size) {
> -                               vk_free2(&device->alloc, NULL, set->dynamic_descriptors);
>                                 vk_free2(&device->alloc, NULL, set);
>                                 return vk_error(VK_ERROR_OUT_OF_POOL_MEMORY_KHR);
>                         }
> --
> 2.9.4
>