[Mesa-dev] [PATCH 00/11] anv: A few refactors and fixes

[Lionel Landwerlin]

Conflicting a bit with some upcoming work here too, but looks good overall :

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>

On 12/07/17 01:04, Jason Ekstrand wrote:
> I started working on another up-and-coming Vulkan feature today and, as is
> frequently the case, found a bunch of bugs along the way.  This tiny little
> series fixes some bugs, does a few cleanups, and does most of the needed
> refactoring for said feature.  The last two patches are the important part.
> They move us away from the world where the binding table building code
> knows about the details of your surface states.
>
> Nanley, I know this series conflicts a bit with what you're working on.
> I'm not in all that much of a rush to land these so don't worry about
> rebasing.
>
> Jason Ekstrand (11):
>    anv: Stop leaking the no_aux sampler surface state
>    anv: Get rid of some unused function declarations
>    anv/cmd_buffer: Properly handle render passes with 0 attachments
>    anv/image: Add INPUT_ATTACHMENT to the list of required usages
>    intel/isl: Add a helper to get a subimage surface
>    intel/isl: Add some sanity checks for compressed surfaces
>    anv: Separate surface states by layout instead of aux_usage
>    anv/image: Use vk_zalloc instead of an explicit memset
>    anv/image: zalloc image views
>    anv/image: Break surface state fill logic into a helper
>    anv: Add a new anv_surface_state struct
>
>   src/intel/blorp/blorp_blit.c          |  38 ++---
>   src/intel/isl/isl.c                   |  35 +++++
>   src/intel/isl/isl.h                   |  23 ++++
>   src/intel/isl/isl_surface_state.c     |  18 +++
>   src/intel/vulkan/anv_blorp.c          |   4 +-
>   src/intel/vulkan/anv_descriptor_set.c |   5 +-
>   src/intel/vulkan/anv_image.c          | 252 +++++++++++++++++++---------------
>   src/intel/vulkan/anv_private.h        |  67 +++++----
>   src/intel/vulkan/genX_cmd_buffer.c    | 144 ++++++++-----------
>   9 files changed, 339 insertions(+), 247 deletions(-)
>