[Mesa-dev] [PATCH 03/10] egl: split _eglParseImageAttribList into per extension functions

[Emil Velikov]

On 13 July 2017 at 08:48, Michel Dänzer <michel at daenzer.net> wrote:
> On 30/06/17 08:15 PM, Emil Velikov wrote:
>> Will allow us to simplify existing code and make further improvements
>> short and simple.
>>
>> No functional change intended.
>
> Famous last words. :)
>
Unfortunately.

> This broke the piglit test
> spec at ext_image_dma_buf_import@ext_image_dma_buf_import-invalid_hints for
> me with radeonsi:
>
> Unexpected EGL error: EGL_BAD_PARAMETER 0x300c
> Expected EGL error: EGL_BAD_ATTRIBUTE 0x3004
> Unexpected EGL error: EGL_BAD_PARAMETER 0x300c
> Expected EGL error: EGL_BAD_ATTRIBUTE 0x3004
> Unexpected EGL error: EGL_BAD_PARAMETER 0x300c
> Expected EGL error: EGL_BAD_ATTRIBUTE 0x3004
> Unexpected EGL error: EGL_BAD_PARAMETER 0x300c
> Expected EGL error: EGL_BAD_ATTRIBUTE 0x3004
>
Seems like we're overriding the EGL_BAD_ATTRIBUTE. Couple of routes
come ti mind - will flip a coin and send a patch in a few minutes.

Thanks
Emil