[Mesa-dev] [PATCH 8/9] anv: don't use strcpy for copying strings

[Grazvydas Ignotas]

On Thu, Jul 13, 2017 at 8:09 PM, Lionel Landwerlin
<lionel.g.landwerlin at intel.com> wrote:
> CID: 1358935
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> ---
>  src/intel/vulkan/anv_device.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
> index 39c907e9f2d..d3607deccfc 100644
> --- a/src/intel/vulkan/anv_device.c
> +++ b/src/intel/vulkan/anv_device.c
> @@ -895,7 +895,8 @@ void anv_GetPhysicalDeviceProperties(
>        .sparseProperties = {0}, /* Broadwell doesn't do sparse. */
>     };
>
> -   strcpy(pProperties->deviceName, pdevice->name);
> +   strncpy(pProperties->deviceName, pdevice->name,
> +           VK_MAX_PHYSICAL_DEVICE_NAME_SIZE);

It will still misbehave if pdevice->name is too long, maybe clear the
last byte manually or use snprintf?

Gražvydas