[Mesa-dev] [PATCH 1/2] anv: Add a new centralized extensions file

[Emil Velikov]

On 14 July 2017 at 07:14, Jason Ekstrand <jason at jlekstrand.net> wrote:
> This will allow us to keep everything in one place when it comes to
> declaring what extensions are supported.
It will also allow radv to reuse the generator (barring some trivial
fixes), if they're interested ;-)

> ---
>  src/intel/Makefile.vulkan.am            |  3 +-
>  src/intel/vulkan/anv_entrypoints_gen.py | 27 +++-----------
>  src/intel/vulkan/anv_extensions.py      | 63 +++++++++++++++++++++++++++++++++
>  3 files changed, 69 insertions(+), 24 deletions(-)
>  create mode 100644 src/intel/vulkan/anv_extensions.py
>
> diff --git a/src/intel/Makefile.vulkan.am b/src/intel/Makefile.vulkan.am
> index 6550f68..d6e11f8 100644
> --- a/src/intel/Makefile.vulkan.am
> +++ b/src/intel/Makefile.vulkan.am
> @@ -24,7 +24,8 @@
>  # out and we'll fail at `make dist'
>  vulkan_api_xml = $(top_srcdir)/src/vulkan/registry/vk.xml
>
> -vulkan/anv_entrypoints.c: vulkan/anv_entrypoints_gen.py $(vulkan_api_xml)
> +vulkan/anv_entrypoints.c: vulkan/anv_entrypoints_gen.py \
> +                         vulkan/anv_extensions.py $(vulkan_api_xml)
Please add the .py file in the EXTRA_DIST list further down.


> diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py
> new file mode 100644
> index 0000000..79d6bb2
> --- /dev/null
> +++ b/src/intel/vulkan/anv_extensions.py
> @@ -0,0 +1,63 @@
> +COPYRIGHT = """\
> +/*
> + * Copyright 2017 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the
> + * "Software"), to deal in the Software without restriction, including
> + * without limitation the rights to use, copy, modify, merge, publish,
> + * distribute, sub license, and/or sell copies of the Software, and to
> + * permit persons to whom the Software is furnished to do so, subject to
> + * the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the
> + * next paragraph) shall be included in all copies or substantial portions
> + * of the Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
> + * OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT.
> + * IN NO EVENT SHALL VMWARE AND/OR ITS SUPPLIERS BE LIABLE FOR
> + * ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
> + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
> + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
> + */
> +"""
> +
> +import argparse
> +import xml.etree.cElementTree as et
> +
> +from mako.template import Template
> +
The copyright and imports above are used in 2/2 and should be part of it.
Not that big of a deal though, so if you want to keep it here - go ahead.

With the EXTRA_DIST bit
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

-Emil