[Mesa-dev] [PATCH] egl: Fix predecence problem when setting __DRI_CTX_FLAG_NO_ERROR

[Grigori Goronzy]

On 2017-07-14 23:30, Kenneth Graunke wrote:
> This accidentally set __DRI_CTX_FLAG_NO_ERROR whenever any flags were
> present.  Just needs extra parenthesis.
> 
> Fixes: 4909519a6655 (egl: Add EGL_KHR_create_context_no_error support)

Reviewed-by: Grigori Goronzy <greg at chown.ath.cx>

Sorry for breaking so much stuff today. :)

> ---
>  src/egl/drivers/dri2/egl_dri2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/egl/drivers/dri2/egl_dri2.c 
> b/src/egl/drivers/dri2/egl_dri2.c
> index f632ebe2551..072494ed4ed 100644
> --- a/src/egl/drivers/dri2/egl_dri2.c
> +++ b/src/egl/drivers/dri2/egl_dri2.c
> @@ -1074,7 +1074,7 @@ dri2_fill_context_attribs(struct
> dri2_egl_context *dri2_ctx,
> 
>        ctx_attribs[pos++] = __DRI_CTX_ATTRIB_FLAGS;
>        ctx_attribs[pos++] = dri2_ctx->base.Flags |
> -            dri2_ctx->base.NoError ? __DRI_CTX_FLAG_NO_ERROR : 0;
> +         (dri2_ctx->base.NoError ? __DRI_CTX_FLAG_NO_ERROR : 0);
>     }
> 
>     if (dri2_ctx->base.ResetNotificationStrategy !=
> EGL_NO_RESET_NOTIFICATION_KHR) {