[Mesa-dev] [PATCH v3 12/14] i965: Pretend that CCS modified images are two planes

Chad Versace chadversary at chromium.org
Fri Jul 14 22:50:59 UTC 2017


On Wed 12 Jul 2017, Jason Ekstrand wrote:
> From: Ben Widawsky <ben at bwidawsk.net>
> 
> v2: move is_aux into if block. (Jason)
> Use else block instead of goto (Jason)
> 
> v3: Fix up logic for is_aux (Ben)
> Fix up size calculations and add FIXME (Ben)
> 
> v4 (Jason Ekstrand):
> Use the aux_pitch in the image instead of calculating it
> 
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> Acked-by: Daniel Stone <daniels at collabora.com>
> Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/intel/isl/isl.h                      |  6 ++++
>  src/mesa/drivers/dri/i965/intel_screen.c | 55 ++++++++++++++++++++------------
>  2 files changed, 40 insertions(+), 21 deletions(-)
> 
> diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h
> index d81df31..7dd3618 100644
> --- a/src/intel/isl/isl.h
> +++ b/src/intel/isl/isl.h
> @@ -1519,6 +1519,12 @@ isl_tiling_to_i915_tiling(enum isl_tiling tiling);
>  const struct isl_drm_modifier_info * ATTRIBUTE_CONST
>  isl_drm_modifier_get_info(uint64_t modifier);
>  
> +static inline bool
> +isl_drm_modifier_has_aux(uint64_t modifier)
> +{
> +   return isl_drm_modifier_get_info(modifier)->aux_usage != ISL_AUX_USAGE_NONE;
> +}

Thanks for this improvement in v3.
Reviewed-by: Chad Versace <chadversary at chromium.org>

If I missed any patches, let me know.


More information about the mesa-dev mailing list