[Mesa-dev] [PATCH] i965/surface_state: Remove the mcs_buf->offset == 0 restriction

Pohjolainen, Topi topi.pohjolainen at gmail.com
Sat Jul 15 17:27:34 UTC 2017


On Fri, Jul 14, 2017 at 10:43:08PM -0700, Kenneth Graunke wrote:
> On Friday, July 14, 2017 3:38:30 PM PDT Jason Ekstrand wrote:
> > This assert was removed in b0cc55f29831638069407a4c1a5c809b26902ab6 but
> > got added back in 1a43d774b613d0b00e26b28cc752d944ce8049aa, probably by
> > accident.
> > ---
> >  src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > index 9ef5076..c252f40 100644
> > --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > @@ -147,7 +147,6 @@ brw_emit_surface_state(struct brw_context *brw,
> >        if (mt->mcs_buf) {
> >           aux_surf = &mt->mcs_buf->surf;
> >  
> > -         assert(mt->mcs_buf->offset == 0);
> >           aux_bo = mt->mcs_buf->bo;
> >           aux_offset = mt->mcs_buf->bo->offset64 + mt->mcs_buf->offset;
> >        } else {
> > 
> 
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

Yep, sorry about that, looks like a rebase mistake:

Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>


More information about the mesa-dev mailing list