[Mesa-dev] [PATCH 4/4] dri: Add KHR_no_error toggle to driconf

[Emil Velikov]

On 13 July 2017 at 12:09, Grigori Goronzy <greg at chown.ath.cx> wrote:
> On 2017-07-12 15:15, Emil Velikov wrote:
>>
>> As mentioned in earlier commit no_error should be device agnostic.
>> Hence removing the st/dri bits and adding a DRI_CONF_MESA_NO_ERROR()
>> line next to DRI_CONF_VBLANK_MODE seems like the better solution.
>>
>
> Hm, driconf overrides are typically set per screen and/or driver, so that
> won't work. The overrides will be ignored because of screen/driver mismatch.
> So I think it needs to be implemented separately for each classic driver.
> I'll keep this part to the Gallium state tracker for now.
>
Hmm my understanding was completely different. Have you tested my
suggestion or this is your assumption?

> By the way, glthread seems to have similar issues even though it is in
> theory independent of driver.
>
Yes glthread is in a similar position. Keeping things as-is (esp.
since your patches landed) is perfectly fine.
If needed we can move things at a later stage.

Thanks again for tackling this.
Emil