[Mesa-dev] [PATCH] st/mesa: init winsys buffers list only if context creation succeeds

Charmaine Lee charmainel at vmware.com
Wed Jul 12 05:14:41 UTC 2017


Fixes piglit test crash when context creation fails.
---
 src/mesa/state_tracker/st_context.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c
index 560d94e..8eccad6 100644
--- a/src/mesa/state_tracker/st_context.c
+++ b/src/mesa/state_tracker/st_context.c
@@ -574,11 +574,11 @@ struct st_context *st_create_context(gl_api api, struct pipe_context *pipe,
    st = st_create_context_priv(ctx, pipe, options, no_error);
    if (!st) {
       _mesa_destroy_context(ctx);
+   } else {
+      /* Initialize context's winsys buffers list */
+      LIST_INITHEAD(&st->winsys_buffers);
    }
 
-   /* Initialize context's winsys buffers list */
-   LIST_INITHEAD(&st->winsys_buffers);
-
    return st;
 }
 
-- 
1.9.1



More information about the mesa-dev mailing list