[Mesa-dev] [PATCH 17/20] i965: Normalize types for FBL, FBH, etc

Kenneth Graunke kenneth at whitecape.org
Tue Jul 18 00:42:37 UTC 2017


On Thursday, July 6, 2017 4:48:27 PM PDT Matt Turner wrote:
> Allows the instructions to be compacted. The documentation claims that
> some of these only accept UD types, even though the type doesn't change
> the operation performed. Just normalize the types to ensure we get
> instruction compaction.
> 
> The only functional changes are for FBL and CBIT (always use UD types)
> and FBH (always use the same types).

I don't know about FBH - that's definitely violating a restriction.
I can't imagine why it would matter, though...is the simulator okay
with this, or does it get cranky?

If the simulator is happy with FBH and D, I guess I'm okay with that.

The rest looks fine.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170717/e190282d/attachment-0001.sig>


More information about the mesa-dev mailing list