[Mesa-dev] [PATCH v2] etnaviv: Add support for ETC2 texture compression

Wladimir laanwj at gmail.com
Tue Jul 18 09:13:50 UTC 2017


> h (format) {
>
> How about
>
> const struct util_format_description *desc = util_format_description(format);
> return desc->layout == UTIL_FORMAT_LAYOUT_ETC;

I intentionally exclude PIPE_FORMAT_ETC1_RGB8 here because it is
implemented on older hw and has its own feature bit
(ETC1_TEXTURE_COMPRESSION).
But yes that shortens the code at least, thanks.

> There's already a util_format_is_s3tc helper, I don't think it'd be
way out of line to add one for etc as well.

Ok, will add one.

Regards,
Wladimir


More information about the mesa-dev mailing list