[Mesa-dev] [PATCH 3/4] docs: avoid overwrite of LD_LIBRARY_PATH during basic testing

[Andres Gomez]

On Tue, 2017-07-18 at 10:48 +0100, Emil Velikov wrote:
> On 15 July 2017 at 17:01, Andres Gomez <agomez at igalia.com> wrote:
> > On Mon, 2017-07-10 at 12:19 +0100, Emil Velikov wrote:
> > > On 8 July 2017 at 20:59, Andres Gomez <agomez at igalia.com> wrote:
> > > > The LD_LIBRARY_PATH environment variable could be already defined so
> > > > we extend it and restore it rather than just overwriting it.
> > > > 
> > > 
> > > Hmm, what are you doing to actually require LD_LIBRARY_PATH in the first place?
> > > It makes it somewhat uneasy that one will have that in their setup.
> > 
> > My everyday's work is done in a JHBuild env that already uses this
> > variable for mesa dependencies. I would have assumed that this is
> > actually quite normal for most of mesa developers, although maybe I'm
> > wrong ...
> > 
> 
> This is the first time I hear anyone working on Mesa use JHBuild.
> There could be some though ;-)

😄

Well, I meant that I assumed it was normal to have LD_LIBRARY_PATH
customized to point to the dependencies, not that it was normal to use
JHBuild 😉

> 
> > > 
> > > > Signed-off-by: Andres Gomez <agomez at igalia.com>
> > > > ---
> > > >  docs/releasing.html | 4 +++-
> > > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/docs/releasing.html b/docs/releasing.html
> > > > index 8e6e4d1a6d..99235d8412 100644
> > > > --- a/docs/releasing.html
> > > > +++ b/docs/releasing.html
> > > > @@ -472,7 +472,8 @@ Here is one solution that I've been using.
> > > >         __glxgears_cmd='glxgears 2>&1 | grep -v "configuration file"'
> > > >         __es2info_cmd='es2_info 2>&1 | egrep "GL_VERSION|GL_RENDERER|.*dri\.so"'
> > > >         __es2gears_cmd='es2gears_x11 2>&1 | grep -v "configuration file"'
> > > > -       export LD_LIBRARY_PATH=`pwd`/test/usr/local/lib/
> > > > +       'x$LD_LIBRARY_PATH' -ne 'x' && __old_ld='$LD_LIBRARY_PATH' && __token=':'
> > > > +       export LD_LIBRARY_PATH=`pwd`/test/usr/local/lib/'${__token}${__old_ld}'
> > > 
> > > AFAICT you don't need __token.
> > 
> > You do if you want to avoid adding ":" at the end when LD_LIBRARY_PATH
> > is not defined previously. It can be done in other ways but I thought
> > this to be the simplest/easiest to read.
> > 
> 
> I was thinking about adding the colon, unconditionally. AFAICT things
> work perfectly fine with it. Even if one extends LD_LIBRARY_PATH at a
> later stage.

Mmmm ... didn't think that was also valid but, I suppose why not. In
any case, it feels odd to me. I don't remember seeing env variables
like that finishing in ":" before.

Not hard thoughts on this. If you prefer to remove __token, I'm OK with
it.

> But if you really want to avoid it this is the shortest way, indeed.
> 
> -Emil
> 
-- 
Br,

Andres