[Mesa-dev] [PATCH] mesa: check API profile for GL_QUADS_FOLLOW_PROVOKING_VERTEX_CONVENTION

[Ian Romanick]

On 07/18/2017 01:20 PM, Brian Paul wrote:
> If we have a compat profile context, it means that GL_QUADS[_STRIP] are
> supported so this query makes sense.  It's also legal for 3.2 core profile
> because of a spec bug.

Do you know of any apps that depend on that spec bug?  In most similar
cases, we've taken the later spec as a clarification, and we've just
done what the later spec says.  That has happened a lot.  Table 6.45
seems to be the only place in the 3.2 core profile spec that mentions
it, and appendix section E.2.2. does say that QUADS and QUAD_STRIP are
removed.

> ---
>  src/mesa/main/get.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
> index 825ea34..68f520f 100644
> --- a/src/mesa/main/get.c
> +++ b/src/mesa/main/get.c
> @@ -1302,7 +1302,7 @@ check_extra(struct gl_context *ctx, const char *func, const struct value_desc *d
>           break;
>        case EXTRA_EXT_PROVOKING_VERTEX_32:
>           api_check = TRUE;
> -         if (version <= 32)
> +         if (ctx->API == API_OPENGL_COMPAT || version == 32)
>              api_found = ctx->Extensions.EXT_provoking_vertex;
>           break;
>        case EXTRA_END:
>