[Mesa-dev] [PATCH mesa] spirv: add missing include path

Eric Engestrom eric.engestrom at imgtec.com
Wed Jul 19 08:39:50 UTC 2017


On Tuesday, 2017-07-18 15:32:27 -0700, Kenneth Graunke wrote:
> On Tuesday, July 18, 2017 11:16:50 AM PDT Emil Velikov wrote:
> > On 18 July 2017 at 19:03, Eric Engestrom <eric.engestrom at imgtec.com> wrote:
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101831
> > > Signed-off-by: Eric Engestrom <eric.engestrom at imgtec.com>
> > > ---
> > >
> > > Note: Android and SCons probably need a similar fix
> > > ---
> > >  src/compiler/Makefile.nir.am | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/src/compiler/Makefile.nir.am b/src/compiler/Makefile.nir.am
> > > index 1533ee536d..002b9fc535 100644
> > > --- a/src/compiler/Makefile.nir.am
> > > +++ b/src/compiler/Makefile.nir.am
> > > @@ -32,6 +32,9 @@ nir_libnir_la_SOURCES =                                       \
> > >         $(SPIRV_GENERATED_FILES)                        \
> > >         $(NIR_GENERATED_FILES)
> > >
> > > +nir_libnir_la_SOURCES = \
> > > +       -I$(top_builddir)/src/compiler/spirv
> > > +
> > This is off - the generated file is missing the srcdir, since it
> > assumes the header to be in the same directory.
> > 
> > Ken should have pushed a fix a second ago.
> > -Emil
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> Sorry, I checked the list for a fix, but missed your patch.
> Hopefully it's fixed now, at any rate.
> 
> --Ken

No worries, my patch was wrong anyway.
I was in a rush, copy/pasted something and it somehow compiled, so
I sent it to the ML and left.

Good thing you looked into it too and provided a correct patch :)


More information about the mesa-dev mailing list