[Mesa-dev] [PATCH] egl: Add MKDIR_GEN definition

[Emil Velikov]

On 19 July 2017 at 09:57, Daniel Stone <daniels at collabora.com> wrote:
> Adding linux-dmabuf Wayland protocol files as generated did the right
> thing, by prepending $(MKDIR_GEN) so autotools didn't try to write into
> a build directory which didn't yet exist.
>
> Unfortunately MKDIR_GEN needs to be defined in every Makefile it's used
> in, and src/egl/ didn't actually have it.
This is way off. One can AC_SUBST() it in configure.ac - simply nobody bothered.
Can you please reword or drop this hunk?

> As unset variables expand to
> NULL, it was silently being skipped.
>
> Copy & paste the defintion to make sure drivers/dri2/ exists before we
> try to generate files into it.
>
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> Reported-by: Nick Sarnie <commendsarnex at gmail.com>
> Reported-by: Mike Lothian <mike at fireburn.co.uk>
> Fixes: 02cc35937277 ("egl/wayland: Use linux-dmabuf interface for buffers")

Regardless of the above nitpick
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>

Thanks
Emil