[Mesa-dev] [PATCH v4 13/18] anv/cmd_buffer: Warn about not enabling CCS_E

[Nanley Chery]

Use the performance warning infrastructure to provide helpful
information when testing applications.

Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
---
 src/intel/vulkan/genX_cmd_buffer.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
index ac40d3c5b9..e52ed74e29 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -270,16 +270,18 @@ color_attachment_compute_aux_usage(struct anv_device * device,
        * also supports color compression.
        */
       if (isl_format_supports_ccs_e(&device->info, iview->isl.format)) {
-         /* TODO: Consider using a heuristic to determine if temporarily enabling
-          * CCS_E for this image view would be beneficial.
-          *
-          * While fast-clear resolves and partial resolves are fairly cheap in the
+         att_state->input_aux_usage = ISL_AUX_USAGE_CCS_D;
+
+         /* While fast-clear resolves and partial resolves are fairly cheap in the
           * case where you render to most of the pixels, full resolves are not
           * because they potentially involve reading and writing the entire
           * framebuffer.  If we can't texture with CCS_E, we should leave it off and
           * limit ourselves to fast clears.
           */
-         att_state->input_aux_usage = ISL_AUX_USAGE_CCS_D;
+         if (cmd_state->pass->attachments[att].first_subpass_layout ==
+             VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) {
+            anv_perf_warn("Not temporarily enabling CCS_E.");
+         }
       } else {
          att_state->input_aux_usage = ISL_AUX_USAGE_NONE;
       }
-- 
2.13.3