[Mesa-dev] [PATCH] egl: Add MKDIR_GEN definition

[Nick Sarnie]

Hi all,

On Wed, Jul 19, 2017 at 4:57 AM, Daniel Stone <daniels at collabora.com> wrote:
> Adding linux-dmabuf Wayland protocol files as generated did the right
> thing, by prepending $(MKDIR_GEN) so autotools didn't try to write into
> a build directory which didn't yet exist.
>
> Unfortunately MKDIR_GEN needs to be defined in every Makefile it's used
> in, and src/egl/ didn't actually have it. As unset variables expand to
> NULL, it was silently being skipped.
>
> Copy & paste the defintion to make sure drivers/dri2/ exists before we
> try to generate files into it.
>
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> Reported-by: Nick Sarnie <commendsarnex at gmail.com>
> Reported-by: Mike Lothian <mike at fireburn.co.uk>

Tested-by: Nick Sarnie <commendsarnex at gmail.com>

> Fixes: 02cc35937277 ("egl/wayland: Use linux-dmabuf interface for buffers")
> ---
>  src/egl/Makefile.am | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/egl/Makefile.am b/src/egl/Makefile.am
> index 19295de3ed..52ded15145 100644
> --- a/src/egl/Makefile.am
> +++ b/src/egl/Makefile.am
> @@ -21,6 +21,8 @@
>
>  include Makefile.sources
>
> +MKDIR_GEN = $(AM_V_at)$(MKDIR_P) $(@D)
> +
>  BUILT_SOURCES =
>
>  AM_CFLAGS = \
> --
> 2.13.2
>

Thanks for looking into it!

Sarnex